Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional argument for variation() #856

Merged
merged 4 commits into from
Mar 18, 2023

Conversation

itsdebartha
Copy link
Contributor

  • Added corrected=true/false for variation
  • Added test for the above addition

This commit addresses #777

Added `corrected=true/false` for variation
Added test for the above addition
@ParadaCarleton
Copy link
Contributor

ParadaCarleton commented Mar 18, 2023

@nalimilan do you know why the docs are failing to build?

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the docstring?

src/scalarstats.jl Outdated Show resolved Hide resolved
@itsdebartha
Copy link
Contributor Author

I also added tests that would use the method of stdm (i.e. specified mean) which were previously not there

@ParadaCarleton
Copy link
Contributor

This looks good, thanks!

@ParadaCarleton ParadaCarleton merged commit 28f70ec into JuliaStats:master Mar 18, 2023
@CarloLucibello
Copy link

tag a new release? it has been a while...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants