Add Convolve for DiscreteNonParametric (Redux) #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscreteNonParametric convolution has a very nice trivial closed form. It was not implemented. This pull request implements it.
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Doesn't preserve the type of the Vector, but perhaps this is better .... Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
use functions to access the support and probabilities, and write as one loop. Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Removed check args: We know the convovultion is a proper distribution.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1850 +/- ##
==========================================
+ Coverage 85.94% 85.95% +0.01%
==========================================
Files 144 144
Lines 8656 8667 +11
==========================================
+ Hits 7439 7450 +11
Misses 1217 1217 ☔ View full report in Codecov by Sentry. |
devmotion
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally implemented by @iampritishpatil here: #1523
This PR additionally implements a number of test improvements suggested by @devmotion. Happy to merge this or complete the original PR.
Thanks!