Fix rand for truncated normal with 0 variance
#1721
Conversation
Fixes issue 1712.
| if a <= μ <= b | ||
| z = 0.0 | ||
| else | ||
| return NaN |
There was a problem hiding this comment.
I think we would want to catch this case earlier in truncated: A distribution with zero mass is by definition not a distribution. See #843.
There was a problem hiding this comment.
Maybe let's throw an error here? I don't think returning NaN is particularly useful.
There was a problem hiding this comment.
I've opened #1723 as a means of catching this case earlier, but I'd also be fine throwing an error here.
|
Seems I was beaten to the punch by about 2 years: #1273 🙂 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1721 +/- ##
==========================================
+ Coverage 85.75% 85.87% +0.11%
==========================================
Files 138 138
Lines 8339 8344 +5
==========================================
+ Hits 7151 7165 +14
+ Misses 1188 1179 -9
☔ View full report in Codecov by Sentry. |
Fixes #1712.