Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend varinfo to include other normalized variants. #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jpfairbanks
Copy link
Contributor

Variation of information can be normalized in different ways based on the properties of the application.
I added a symbol argument to specify this normalization to the varinfo function and set the default to the previous behavior. I also put the computation of I, H1, H2 into a function information so that it could be reused in the future. This is a nonbreaking change.

If there is a better way to do it, let me know and I can change the pull request. I think this is the least disruptive change possible. I added tests and documentation to match what was there.

The paper cited is here
http://jmlr.csail.mit.edu/papers/volume11/vinh10a/vinh10a.pdf

@pcjentsch
Copy link

This PR would be useful to me, what prevented it from being merged?

The same authors that @jpfairbanks cites have since published a follow-up paper, which brought me to this PR.

@alyst
Copy link
Member

alyst commented Jun 12, 2022

@pcjentsch I guess it was a lack of maintainers resources :( Unfortunately, the PR was submitted quite long time ag, and the codebase has changed since. To the level that there are merge conflicts, and it cannot be merged automatically. If @jpfairbanks would be so kind to review and rebase his work, I would be happy to review it. Alternatively ‐ if he would be ok with that - you can fork this PR and submit an updated version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants