Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nonparametric heading test issue (in RoME.jl) #1760

Open
dehann opened this issue Jul 21, 2023 · 6 comments
Open

fix nonparametric heading test issue (in RoME.jl) #1760

dehann opened this issue Jul 21, 2023 · 6 comments

Comments

@dehann
Copy link
Member

dehann commented Jul 21, 2023

See @test_broken here:

@dehann dehann added this to the v0.0.x milestone Jul 21, 2023
@Affie Affie modified the milestones: v0.0.x, v0.35.0 Oct 20, 2023
@Affie Affie self-assigned this Oct 20, 2023
@dehann
Copy link
Member Author

dehann commented Oct 20, 2023

try to do for v0.35.0, would like to ensure partials working properly for RoME. Small chance this punts to v0.35.1 given other priorities needing v0.35.0.

@dehann
Copy link
Member Author

dehann commented Oct 20, 2023

spike and bump to v0.35.1 if taking too long

@Affie
Copy link
Member

Affie commented Oct 25, 2023

Testing: So far approxConvBelief gives the correct answers.

@dehann
Copy link
Member Author

dehann commented Oct 25, 2023

this is new test coverage, and test looks at implicit partial priors and graph is still fully defined. Decision on how to handle these partials either explicit or code improvements with Manifolds.

Way back before Manifolds and StaticArrays this would work because the implicit partial was handled automatically since all compute and variable assignments were done in coordinates and using manifold dims of variables and factors (i.e. xDim and zDim).

@Affie Affie modified the milestones: v0.35.0, v0.35.1 Oct 25, 2023
@dehann
Copy link
Member Author

dehann commented Oct 25, 2023

requires new design session on partials, which expected to occur in the near future

@dehann
Copy link
Member Author

dehann commented Oct 25, 2023

quick discussion had preference for always having "partial" info available for each factor. I.e. solver can recover necessary partial info for any factor. Preference to avoid having multiple factors for the same measurement type on different graphs. Example PriorPosition2/PriorPose2_XY/PriorPose3_XY.

@dehann dehann modified the milestones: v0.35.1, v0.35.2 Nov 14, 2023
@dehann dehann modified the milestones: v0.35.2, v0.35.3, v0.35.4 Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants