Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade parametric batch solve to fully support Manifolds.jl using Manopt.jl #1524

Open
Affie opened this issue May 9, 2022 · 1 comment

Comments

@Affie
Copy link
Member

Affie commented May 9, 2022

No description provided.

@dehann
Copy link
Member

dehann commented May 9, 2022

Yes, let's convert one or two factors to Manopt.jl and work it incrementally from there.

Shall we transition the newest abstract to Manopt away from Optim to do this?
https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/blob/bfa8a2ae72cdabb352d193deef86bf7ab2877ba9/src/entities/DFGFactor.jl#L13


EDIT, we can leave AbstractRelativeMinimize with Optim.jl. Might be cause to override the some of the Optim.jl functionality here, such that it can work with tangents and retractions rather than coordinates. Only if there are issues with Manopt (unlikely). Either way should be easy/good to support Manopt for Manifolds related optimization anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants