adding the trace-compile option to the julia initialization #530
Conversation
|
Thanks. Could you work on updating the tests? |
|
I'll take a look and push another commit soon, thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
==========================================
+ Coverage 85.22% 87.60% +2.37%
==========================================
Files 39 40 +1
Lines 2342 2364 +22
==========================================
+ Hits 1996 2071 +75
+ Misses 346 293 -53 ☔ View full report in Codecov by Sentry. |
|
I fixed all errors in existing tests and I added a new test specifically for the new If you can take a look now, that'd be great. @mkitti |
| ) | ||
| ) | ||
| assert (trace_compile_path).exists() | ||
| assert len(trace_compile_path.read_text().strip()) > 0 |
There was a problem hiding this comment.
Is there some compilation string that you know should be printed to this file? If so, could you test that it actually shows up there?
There was a problem hiding this comment.
Yes, that's a great idea! I added a check for the precompilation directive of the sin function we invoke to test precompilation.
|
I think with the additional test, this should look better now. Thanks for taking a look @MilesCranmer |
It'd be nice to be able to trace the compilation performed by Julia called via PyJulia. The main use case is for the precompilation of a Julia library triggered primarily through their Python interface.
The change is a single line adding the
trace-compileoption.