Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow building sysimage with custom PyCall #422

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

marius311
Copy link
Contributor

The current sysimage just installs the latest PyCall from the registry. This adds a --pycall-env option which lets you bake in an existing one from any project you want,

$ python -m julia.sysimage --pycall-env . sys.so # take PyCall from the project in the current folder

I found this useful in my debugging / developing, and I think it'd be nice to have in the official repo.

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #422 into master will decrease coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   87.48%   87.38%   -0.11%     
==========================================
  Files          39       39              
  Lines        2246     2251       +5     
==========================================
+ Hits         1965     1967       +2     
- Misses        281      284       +3     
Impacted Files Coverage Δ
src/julia/sysimage.py 72.36% <50.00%> (-2.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25049e3...302c314. Read the comment docs.

@tkf
Copy link
Member

tkf commented Sep 16, 2020

Thanks! Yes, it'd be nice to have.

Can you add a test for this? You can put it in https://github.com/tkf/pyjulia/blob/pyjuliatester/src/julia/tests/test_sysimage.py

Also, I wonder if it makes sense to call --pycall-env something else. For example, it might be useful to list, e.g., PyPlot and Plots in such an environment (even though currently they are not get loaded). Maybe --sysimage-env? Though --pycall-env kinda still makes sense since we always have PyCall in it.

Other than that, it LTGM!

@mkitti
Copy link
Member

mkitti commented Nov 23, 2022

Did we ever add a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants