Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch argument order of pyconvert_add_rule #367

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Switch argument order of pyconvert_add_rule #367

wants to merge 3 commits into from
+86 −83

Conversation

LilithHafner
Copy link
Contributor

Fixes #363

@LilithHafner LilithHafner marked this pull request as ready for review September 21, 2023 17:35
@cjdoris cjdoris self-requested a review September 21, 2023 21:17
@cjdoris
Copy link
Collaborator

cjdoris commented Sep 21, 2023

Looks good thanks.

Will merge later - PythonCall is undergoing a refactor right now (for my future sanity) so I'm not merging PRs until that's done.

@cjdoris cjdoris added the priority Should be fixed or implemented soon label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdoris cjdoris Awaiting requested review from cjdoris

Assignees
No one assigned
Labels
priority Should be fixed or implemented soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why does the argument order of pyconvert_add_rule deviate from convention
2 participants
@LilithHafner @cjdoris