Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sparse array conversion #918

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Roger-luo
Copy link

fix #204

@tkf tkf closed this Oct 24, 2021
@tkf tkf reopened this Oct 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021

Codecov Report

Merging #918 (f04535a) into master (f77394b) will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
+ Coverage   67.97%   68.33%   +0.35%     
==========================================
  Files          20       21       +1     
  Lines        2033     2021      -12     
==========================================
- Hits         1382     1381       -1     
+ Misses        651      640      -11     
Flag Coverage Δ
unittests 68.33% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/conversions.jl 63.32% <ø> (ø)
src/scipy.jl 100.00% <100.00%> (ø)
src/PyCall.jl 70.39% <0.00%> (-0.31%) ⬇️
src/startup.jl 53.12% <0.00%> (+4.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77394b...f04535a. Read the comment docs.

python-version: ['3.x']
python-version: ['3.9']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for experimenting if windows failure is due to the missing wheel for 3.10

https://github.com/JuliaPy/PyCall.jl/runs/3987045445?check_suite_focus=true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so it works with 3.9 https://github.com/JuliaPy/PyCall.jl/runs/3987137563?check_suite_focus=true

We either need to wait for SciPy dev to upload the wheel or implement some workaround here.

@Roger-luo
Copy link
Author

Thanks for reviving this! I didn't notice the CI not passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to sparse
3 participants