Skip to content

Commit

Permalink
version stdlibs (#1063)
Browse files Browse the repository at this point in the history
* version stdlibs, which requires Julia 1.6

* try with Julia 1.4

* use "six" not "pyzmq" to test pyimport_conda

* whoops
  • Loading branch information
stevengj committed Nov 8, 2023
1 parent 69f9157 commit 3df5c48
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
5 changes: 5 additions & 0 deletions Project.toml
Expand Up @@ -16,7 +16,12 @@ VersionParsing = "81def892-9a0e-5fdd-b105-ffc91e053289"
Conda = "1.9"
MacroTools = "0.4, 0.5"
VersionParsing = "1.0"

julia = "1.4"
Dates = "1.4"
Libdl = "1.4"
LinearAlgebra = "1.4"
Serialization = "1.4"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand Down
10 changes: 5 additions & 5 deletions test/runtests.jl
Expand Up @@ -393,12 +393,12 @@ const PyInt = pyversion < v"3" ? Int : Clonglong
@test !ispynull(pyimport_conda("inspect", "not a conda package"))
import Conda
if PyCall.conda
# import pyzmq to test PR #294
let already_installed = "pyzmq" Conda._installed_packages()
@test !ispynull(pyimport_conda("zmq", "pyzmq"))
@test "pyzmq" Conda._installed_packages()
# import six to test PR #294
let already_installed = "six" Conda._installed_packages()
@test !ispynull(pyimport_conda("six", "six"))
@test "six" Conda._installed_packages()
if !already_installed
Conda.rm("pyzmq")
Conda.rm("six")
end
end
end
Expand Down

2 comments on commit 3df5c48

@stevengj
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/94950

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.96.2 -m "<description of version>" 3df5c48cdbb0c21b748bc12dbfd4e8fdd8e7ca30
git push origin v1.96.2

Please sign in to comment.