Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add satified_skip_solve as a keyword argument for Conda.add #241

Merged
merged 4 commits into from Jun 12, 2023

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented Jun 12, 2023

Add --satisified-skip-solve as an argument for Conda.add.

This will allow PyCall.jl to ensure that numpy is installed, but not update it if it already in the environment.

@MilesCranmer
Copy link

MilesCranmer commented Jun 12, 2023

LGTM

The CI is broken FYI, so just merge

@mkitti
Copy link
Member Author

mkitti commented Jun 12, 2023

Yes, but why?

@MilesCranmer
Copy link

Broken since November: https://github.com/JuliaPy/Conda.jl/commits/master

@mkitti
Copy link
Member Author

mkitti commented Jun 12, 2023

Yes, but why is CI so broken.

@MilesCranmer
Copy link

@stevengj any idea?

@mkitti
Copy link
Member Author

mkitti commented Jun 12, 2023

What is happening on Windows?

AttributeError: module 'brotli' has no attribute 'error'

@stevengj
Copy link
Member

LGTM. The CI problem on Windows is not a regression so it shouldn't be blocking.

@stevengj stevengj merged commit 0a0cc48 into JuliaPy:master Jun 12, 2023
6 of 9 checks passed
@davidanthoff
Copy link

This seems to breaks CI on x86 ubuntu workflows, see here.

Could this be reverted for now?

Also, the CI here seems unfortunately limited, shouldn't it run on more Julia versions and on things like x86?

@mkitti
Copy link
Member Author

mkitti commented Jul 15, 2023

I guess that is because there is no miniforge for x86:
https://github.com/conda-forge/miniforge

@mkitti
Copy link
Member Author

mkitti commented Jul 15, 2023

Is there commercial miniconda for x86? https://docs.conda.io/en/latest/miniconda.html

@davidanthoff
Copy link

There seems to be something, right? It does look like some kind of conda gets installed... There is an info that says that miniconda is being installed.

@mkitti
Copy link
Member Author

mkitti commented Jul 16, 2023

My guess is that we are pulling in a very old version of conda when x86 was supported. I will investigate further before trying to sort out the fix.

@mkitti
Copy link
Member Author

mkitti commented Jul 18, 2023

@davidanthoff My proposed fix is JuliaPy/PyCall.jl#1045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants