Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Python 3.6 instead of 3.7 #129

Closed
wants to merge 1 commit into from
Closed

Default to Python 3.6 instead of 3.7 #129

wants to merge 1 commit into from

Conversation

tkf added a commit to tkf/PyCall.jl that referenced this pull request Oct 13, 2018
tkf added a commit to tkf/PyCall.jl that referenced this pull request Oct 13, 2018
@stevengj
Copy link
Member

If we do this, what is the upgrade path for existing users when we eventually switch to 3.7? We don't want to tell everyone to Conda.free("python=3.6") manually…

@stevengj
Copy link
Member

One option would be to use MINICONDA_VERSION="3.6", since this string is now saved between updates … if we notice that this number has increased we could free the old version.

@tkf
Copy link
Member Author

tkf commented Oct 13, 2018

The easiest (non?) solution is to just downgrade Python to 3.6 without pinning. It's then almost equivalent to the current situation before this PR except that it reduces the probability of accidental downgrade. Python would be automatically upgraded by Conda.add(package) once 3.6 becomes too old to install the package.

If you want a more controlled solution then I guess we can check Python version in build.jl or __init__? Automatic upgrade in build.jl is probably rather too brutal but maybe we can print something like "Your Python version is becoming old. Run Codna.update() to upgrade Python and Python packages."

tkf added a commit to tkf/PyCall.jl that referenced this pull request Nov 1, 2018
@tkf tkf mentioned this pull request Nov 12, 2018
@tkf
Copy link
Member Author

tkf commented Nov 12, 2018

I think JuliaPy/PyCall.jl#613 is a better solution. It may still make sense to add Conda.pin and Conda.free.

@tkf tkf closed this Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda.add may downgrade Python
2 participants