Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Cubic Hermite Splines (and monotone splines) #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cc7768
Copy link

@cc7768 cc7768 commented Apr 21, 2016

Work in progress with @sglyon. This PR (when it is finished) would address #105

Plan: Cubic Hermite splines use information about both the value and derivative of the function. The plan is to allow for users to give both pieces of information if they would like, but if they only give values then we can construct an approximation of the derivative for them (using a specific approximation that preserves monotonicity).

Progress: A long way to go, but I thought I would open PR so no work got duplicated (and as a commitment device to myself). We have a (very) crude 1d implementation that seems to work for interpolating data.

Next: Our next step is that we need to plug this into the Interpolations.jl framework i.e. make sure we write the right indexing functions etc... Will keep people updated.

@tomasaschan
Copy link
Contributor

Nice!

Hermite splines are not inherently cubic, right? How difficult would it be to generalize the implementation to support (at least) lower orders too?

@cc7768
Copy link
Author

cc7768 commented Apr 25, 2016

Hermite splines aren't inherently cubic, but that seems to be the main use case. I don't know how hard it would be to generalize the implementation:

  • Linear: Not sure that implementing these would be worthwhile because they should be equivalent to linear b-splines
  • Quadratic: Might be worth doing, though they seem to be used very infrequently. Relevant paper: On Shape Preserving Quadratic Spline Interpolation

Will let you know how much effort implementing the quadratic version looks like it will be as I have time to work on this.

@appleparan
Copy link

Why this one not merged at that time? It could be worth to merge and add Linear & quadratic later.

@cc7768
Copy link
Author

cc7768 commented Oct 13, 2016

I haven't made time to finish this, so there isn't anything worth merging.

Likely won't have a chance to do this before new year. Depends on how some other things progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants