docs: introduce MosaicViews as dataset preview utils #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 21.06% 30.31% +9.25%
==========================================
Files 30 32 +2
Lines 679 795 +116
==========================================
+ Hits 143 241 +98
- Misses 536 554 +18
Continue to review full report at Codecov.
|
When building documentation locally we need to manually do `]dev .` to tell Julia use dev version of MLDatasets, and this immediately updates the Project.toml file, to keep it complete I commit this change . This change won't affect docs CI.
johnnychen94
force-pushed
the
jc/preview_dataset
branch
from
ae7e54c
to
d1ab622
Compare
Hmmm, any ideas why the documentation CI is complaining? I get it working locally
|
Comment on lines
+61
to
+62
| For image dataset, [`MosaicViews`](https://github.com/JuliaArrays/MosaicViews.jl) provides a very simple interface to display a list | ||
| of images. |
There was a problem hiding this comment.
The fact that MosaicViews is not directly used in the code below is a bit confusing.
Maybe we can just point to the mosaic function from ImageCore.
|
no idea why Documentation CI is failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.