Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix is_juliaup_installed for invalid path #880

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Mar 27, 2024

This PR:

@t-bltg t-bltg changed the title fix is_juliaup_installed fix is_juliaup_installed for invalid path Mar 27, 2024
@t-bltg t-bltg marked this pull request as draft March 27, 2024 12:51
@t-bltg t-bltg marked this pull request as ready for review March 27, 2024 13:58
@t-bltg
Copy link
Contributor Author

t-bltg commented Apr 18, 2024

@davidanthoff, bump ?

Copy link
Sponsor Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a Rust programmer but this looks reasonable to me. If no feedback in a week, I will merge.

@davidanthoff
Copy link
Collaborator

Hm, I'm not sure this is a good idea. If the user has a script juliaup on the PATH then things are really broken already, and I'm almost thinking we should just abort install at that point. What would be good is a better error message, for example something like "Your system has a broken juliaup command on the PATH, please first remove that" or something along those lines.

Could you move the unrelated typo fix to a different PR? Thanks!

@t-bltg
Copy link
Contributor Author

t-bltg commented May 2, 2024

If the user has a script juliaup on the PATH then things are really broken already, and I'm almost thinking we should just abort install at that point

Exactly. Currently, juliaup returns a false positive as exposed in #879, and is thus a bug. This PR corrects this behaviour.

@t-bltg t-bltg mentioned this pull request May 2, 2024
@t-bltg
Copy link
Contributor Author

t-bltg commented May 2, 2024

Could you move the unrelated typo fix to a different PR?

Done in #916.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

juliainstaller up fails when juliaup fails to execute
3 participants