stronger warnings about changing constants in help and docs #28711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
Aug 17, 2018
base/docs/basedocs.jl
Outdated
| warning from the compiler. The only strict requirement is that the *type* of the | ||
| variable does not change, which is why `const` variables are much faster than regular | ||
| globals. | ||
| In some cases changing the value of a `const` variable is allowed, and results |
There was a problem hiding this comment.
Instead of "allowed" perhaps say that it will not error?
JeffBezanson
force-pushed
the
jb/constdoc
branch
from
0cf9b7e
to
488a195
Compare
KristofferC
pushed a commit
that referenced
this pull request
Sep 10, 2018
[ci skip] (cherry picked from commit 4b103ef)
Merged
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
[ci skip] (cherry picked from commit 4b103ef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #28689