Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate vectorized ceil methods in favor of compact broadcast syntax #18586

Closed
wants to merge 1 commit into from

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Sep 19, 2016

This PR deprecates all remaining vectorized ceil methods (less those for SparseVectors, separate PR) in favor of compact broadcast syntax. Ref. #16285, #17302, #18495, #18512, #18513, #18558, #18564, #18566, #18571 #18575, and #18576. Best!

(Unlike with float, real, etc., the remaining vectorized ceil methods never alias their input. This PR should be less controversial than #18495, #18512, and #18513 as a result.)

@Sacha0
Copy link
Member Author

Sacha0 commented Sep 20, 2016

Travis x64 linux failure seemingly unrelated?

@Sacha0
Copy link
Member Author

Sacha0 commented Dec 23, 2016

Rebased. Best!

@Sacha0 Sacha0 added this to the 0.6.0 milestone Dec 23, 2016
@tkelman
Copy link
Contributor

tkelman commented Dec 23, 2016

do we now have these structured xdiagonal types returning sparse for general broadcast functions that aren't special cased?

@Sacha0
Copy link
Member Author

Sacha0 commented Dec 23, 2016

do we now have these structured xdiagonal types returning sparse for general broadcast functions that aren't special cased?

Not yet, no. I have not been prioritizing that change given discussion in #18590. Thoughts? Thanks!

@tkelman
Copy link
Contributor

tkelman commented Dec 23, 2016

it's what the general sparse types do, right? how hard would it be to plug a few of the structured types into the same mechanism? otherwise will they return dense if you put them through a fused zero-preserving operation? there's a workaround of explicitly converting to sparse, but if there are operations where that's always a better thing to do then return dense, seems we might want to make it automatic

@Sacha0
Copy link
Member Author

Sacha0 commented Dec 24, 2016

Achieving that behavior (if inefficiently, by promoting structured arguments to sparse equivalents prior to broadcast) shouldn't be too difficult. Might take some time though, and seems lower priority than e.g. finishing this series of PRs? Best!

@tkelman
Copy link
Contributor

tkelman commented Dec 24, 2016

agreed, material for a separate PR

@Sacha0
Copy link
Member Author

Sacha0 commented Dec 31, 2016

Subsumed by #19791.

@Sacha0 Sacha0 closed this Dec 31, 2016
@Sacha0 Sacha0 deleted the devecceil branch December 31, 2016 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:broadcast Applying a function over a collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants