Skip to content

Commit

Permalink
remove vestigial code related to (removed) custom inlining of ^
Browse files Browse the repository at this point in the history
  • Loading branch information
JeffBezanson authored and Keno committed Oct 4, 2018
1 parent 5bc3de4 commit b8ca1a4
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions base/compiler/abstractinterpretation.jl
Expand Up @@ -759,23 +759,6 @@ function abstract_call(@nospecialize(f), fargs::Union{Tuple{},Vector{Any}}, argt
return Type # don't try to infer these function edges directly -- it won't actually come up with anything useful
end

if sv.params.inlining
# need to model the special inliner for ^
# to ensure we have added the same edge
if isdefined(Main, :Base) &&
((isdefined(Main.Base, :^) && f === Main.Base.:^) ||
(isdefined(Main.Base, :.^) && f === Main.Base.:.^)) &&
length(argtypes) == 3 && (argtypes[3] Int32 || argtypes[3] Int64)

a1 = argtypes[2]
basenumtype = Union{CoreNumType, Main.Base.ComplexF32, Main.Base.ComplexF64, Main.Base.Rational}
if a1 basenumtype
ftimes = Main.Base.:*
ta1 = widenconst(a1)
abstract_call_gf_by_type(ftimes, Any[ftimes, a1, a1], Tuple{typeof(ftimes), ta1, ta1}, sv)
end
end
end
return abstract_call_gf_by_type(f, argtypes, atype, sv)
end

Expand Down

2 comments on commit b8ca1a4

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.