Add precompiled tags if backedge is missing #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In JuliaLang/julia#49617 it was found that not all callees have backedges to callers. There is some speculation that rather than adding the backedge to those cases, we may in fact be able to prune the backedge graph more substantially in cases where it may be safe to avoid propagating invalidation. Consequently, to enforce the guarantees made by `@compile_workload`, PrecompileTools should check the inference graph and add tags in cases where a backedge is missing.
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 87.17% 88.46% +1.28%
==========================================
Files 1 1
Lines 39 52 +13
==========================================
+ Hits 34 46 +12
- Misses 5 6 +1
|
This was referenced May 3, 2023
This was referenced May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JuliaLang/julia#49617 it was found that
not all callees have backedges to callers. There is some speculation
that rather than adding the backedge to those cases, we may in fact
be able to prune the backedge graph more substantially in cases where
it may be safe to avoid propagating invalidation.
Consequently, to enforce the guarantees made by
@compile_workload,PrecompileTools should check the inference graph and add tags in cases
where a backedge is missing.