use the correct TOML.Parser coupled to Base.TOMLCache
#3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Feb 7, 2024
| const TOML_LOCK = ReentrantLock() | ||
| _parsefile(toml_file::AbstractString) = Base.parsed_toml(toml_file, TOML_CACHE, TOML_LOCK) | ||
| function parsefile(in_memory_registry::Union{Dict, Nothing}, folder::AbstractString, file::AbstractString) | ||
| if in_memory_registry === nothing | ||
| return _parsefile(joinpath(folder, file)) | ||
| else | ||
| content = in_memory_registry[to_tar_path_format(file)] | ||
| return TOML.Internals.parse(TOML.Parser(content; filepath=file)) | ||
| return TOML.Internals.parse(Base.TOML.Parser(content; filepath=file)) |
There was a problem hiding this comment.
Seems odd to use TOML.Internals here but pass Base.TOML as an argument. Maybe instead change using TOML to using Base.TOML at the top of the file?
|
Bump |
|
bump? |
|
I don't know why this was put on the milestone, it's been like this for years. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaLang/julia#53196