Adapting TaylorSeries # 312 #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4694484458Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Project.toml
Outdated
| julia = "1.6, 1.7" | ||
| TaylorIntegration = "0.11" | ||
| TaylorSeries = "0.13" | ||
| julia = "1.6, 1" |
There was a problem hiding this comment.
I think this is the same of just 1.6
|
@schillic I'm replying to your comment here: The tests do pass here, because I am skipping the problematic tests. I will merge a new PR in parallel (with the changes implemented so far here), to keep this PR open since the issue related to JuliaDiff/TaylorSeries.jl#312 hasn't been solved; I'll also tag a new version. |
|
Closed by mistake... I'll take care of this later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaylorSeries #312 solved some inconsistencies that involve
Taylor1{Interval{T}}; the changes broke some tests here, that involveTaylorModel1{TaylorN}andRTaylorModel1{TaylorN}only with thelogfunction. This PR aims solving that.I currently suspect that the these tests fail because, somehow we end up being outside of the domain...