Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation of TaylorNModel #145

Closed
wants to merge 1 commit into from
Closed

Update documentation of TaylorNModel #145

wants to merge 1 commit into from

Conversation

schillic
Copy link
Contributor

I was not sure how to describe order_bounds.

@@ -6,14 +6,15 @@ degree(f::TaylorN) = f.order
setindex!(f::TaylorN, x, i) = f.coeffs[i+1] = x

doc"""
A `Taylor1Model` represents a polynomial approximation to a function $f(t)$ of a single variable.
A `TaylorNModel` represents a polynomial approximation to a function $f(t)$ of `N` independent variables.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you just updated, so it's not your fault, but I dont think that is correct, I would say a taylor model is a rigorous approximation of a function composed by a polynomial approximation and an interval bound on the error

@coveralls
Copy link

coveralls commented Feb 21, 2023

Pull Request Test Coverage Report for Build 4235146100

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.057%

Totals Coverage Status
Change from base Build 4125212071: 0.0%
Covered Lines: 1
Relevant Lines: 1761

💛 - Coveralls

@lucaferranti
Copy link
Member

WoW! quite a lot of damage for a docstring update! 🤣

Just kiding it fails on main too. @lbenet do you remember off the top of your head if some feature depending on 1.9 was recently introduced? Otherwise I can try to have a look at this at some point (this is not related to this MR though)

@lucaferranti
Copy link
Member

relevant stacktrace

ERROR: LoadError: UndefVarError: RetAlloc not defined
Stacktrace:
 [1] getproperty(x::Module, f::Symbol)
   @ Base ./Base.jl:31
 [2] top-level scope
   @ ~/work/TaylorModels.jl/TaylorModels.jl/src/validatedODEs.jl:420
 [3] include(mod::Module, _path::String)

@lbenet
Copy link
Member

lbenet commented Feb 21, 2023

The problems were introduced by merging JuliaDiff/TaylorSeries.jl#312. TS was processing inconsistently the series of some functions for intervals, in the sense of not caring for the natural domain of the function. I started working on that, but got distracted. Sorry...

@schillic
Copy link
Contributor Author

Given that the build failures are unrelated, is there anything you expect me to do here?

@lbenet
Copy link
Member

lbenet commented Apr 13, 2023

Regarding Taylor1Model and TaylorNModel, these were some structs defined during early essays, which have been left there; they do not allow the functionality that has been implemented for TaylorModel1 and TaylorModelN. So, I don't think it is worth using them... Sorry for the very late response, I just noticed this.

Regarding the failure of the tests, as I mentioned it is related to JuliaDiff/TaylorSeries.jl#312; it seems to me that the problem is the tests we implemented for TaylorModel1{TaylorN{T}}. Again, I haven't had time to get into that, but I'll try to remedy soon.

@schillic
Copy link
Contributor Author

Okay, then I close this PR.

@schillic schillic closed this Apr 13, 2023
@schillic schillic deleted the patch-1 branch April 13, 2023 18:46
@lbenet
Copy link
Member

lbenet commented Apr 13, 2023

Thanks... and sorry for the veeery late response...

@schillic
Copy link
Contributor Author

No problem. Regarding the other problem, you have a branch that seems to work (#146). Maybe you can just merge that? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants