New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation of TaylorNModel #145
Conversation
@@ -6,14 +6,15 @@ degree(f::TaylorN) = f.order | |||
setindex!(f::TaylorN, x, i) = f.coeffs[i+1] = x | |||
|
|||
doc""" | |||
A `Taylor1Model` represents a polynomial approximation to a function $f(t)$ of a single variable. | |||
A `TaylorNModel` represents a polynomial approximation to a function $f(t)$ of `N` independent variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you just updated, so it's not your fault, but I dont think that is correct, I would say a taylor model is a rigorous approximation of a function composed by a polynomial approximation and an interval bound on the error
Pull Request Test Coverage Report for Build 4235146100
💛 - Coveralls |
WoW! quite a lot of damage for a docstring update! 🤣 Just kiding it fails on main too. @lbenet do you remember off the top of your head if some feature depending on 1.9 was recently introduced? Otherwise I can try to have a look at this at some point (this is not related to this MR though) |
relevant stacktrace
|
The problems were introduced by merging JuliaDiff/TaylorSeries.jl#312. TS was processing inconsistently the series of some functions for intervals, in the sense of not caring for the natural domain of the function. I started working on that, but got distracted. Sorry... |
Given that the build failures are unrelated, is there anything you expect me to do here? |
Regarding Regarding the failure of the tests, as I mentioned it is related to JuliaDiff/TaylorSeries.jl#312; it seems to me that the problem is the tests we implemented for |
Okay, then I close this PR. |
Thanks... and sorry for the veeery late response... |
No problem. Regarding the other problem, you have a branch that seems to work (#146). Maybe you can just merge that? :) |
I was not sure how to describe
order_bounds
.