Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for FileIO #35

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rakeshksr
Copy link
Contributor

This PR adds support for FileIO.jl and Base.show method for OpenCV.Mat format.
Awaiting JuliaIO/FileIO.jl#381 to merge.
Covers most of #34.
Closes #30 .

@rakeshksr
Copy link
Contributor Author

Image preview working fine Pluto.jl, Ijulia and VS Code.

VS Code

vscode

Pluto.jl

pluto

IJulia

ijulia

@rakeshksr rakeshksr marked this pull request as ready for review January 4, 2024 11:40
@rakeshksr
Copy link
Contributor Author

@ashwani-rathee
The PR JuliaIO/FileIO.jl#381, which this PR relied on, has been successfully merged. With that dependency out of the way, I'd be grateful if you could take a look at this PR

@rakeshksr
Copy link
Contributor Author

@ashwani-rathee Gentle bump

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 16.12903% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 16.12%. Comparing base (03b605d) to head (6a189ca).

Files Patch % Lines
src/fileio.jl 17.85% 23 Missing ⚠️
src/show.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##            master      #35       +/-   ##
============================================
- Coverage   100.00%   16.12%   -83.88%     
============================================
  Files            1        2        +1     
  Lines            1       31       +30     
============================================
+ Hits             1        5        +4     
- Misses           0       26       +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Base.show for OpenCV.Mat image
1 participant