Backports for 0.12.11 #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also optimizes conversion methods and changes the results slightly.
…iaGraphics#441) This slightly changes the results for colors with low-precision eltypes (e.g. `N0f8`).
`pow12_5` is used in the `RGB{Float64}`-->`XYZ` conversion.
This ensures sufficient accuracy (~2 ULP) in the range of [0.09, 1],
which is typically required for the conversion.
`@inline` could be a workaround for the problem with precompilation.
…t32)` (JuliaGraphics#485) `pow5_12(::Float64)` is used in the `XYZ{Float64}`-->`RGB` conversion. This ensures sufficient accuracy (~3 ULP) in the range of [0.003, 1], which is typically required for the conversion. Previously, even conversions from `XYZ{::Float32}` were calculated with `Float64`. This changes the conversions so that `pow5_12(::Float32)` is used. However, `pow5_12(::Float32)` still be calculated within `Float64` for accuracy. `@inline` could be a workaround for the problem with precompilation.
This makes the cube root to be inlined to make it suitable for vectorization. This is intended to reduce precompilation problems rather than increase the speed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-0.12 #549 +/- ##
================================================
+ Coverage 90.89% 97.26% +6.37%
================================================
Files 9 10 +1
Lines 999 1097 +98
================================================
+ Hits 908 1067 +159
+ Misses 91 30 -61 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I
cherry-picked the commits that had no breaking changes and could be merged automatically.Improvement in speed may be limited due to partial backporting.
Please note especially the change in #441.