Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversions to and from Oklab and LCHOklab #518

Closed
wants to merge 4 commits into from

Conversation

nealmckee
Copy link

@nealmckee nealmckee commented Jan 1, 2022

Currently failing as the type doesn’t exist yet.

To and from XYZ, everything else through XYZ.

I’m using the original specifications provided here: https://bottosson.github.io/posts/oklab/

This is my first contribution to Julia, or any software package for that matter, so any help would be greatly appreciated. For example, should I also add this to the docs?

See also JuliaGraphics/ColorTypes.jl#271

@Artoria2e5
Copy link

LCHOklab is known as Oklch now after CSS4.

@eprovst eprovst mentioned this pull request Aug 1, 2023
@jariji
Copy link

jariji commented Feb 5, 2024

It's reported that

unfortunately Colors.jl has been without maintainers for a couple of years; kimikage stepped away, and timholy and johnnychen are too busy elsewhere… It needs someone with the time,authority, and expertise to take up the challenge. But hopefully one day your PRs will be merged!

@timholy
Copy link
Member

timholy commented Feb 6, 2024

Yes. Not quite sure I understand, are you volunteering @jariji ?

@timholy
Copy link
Member

timholy commented Feb 6, 2024

This needs tests.

@jariji
Copy link

jariji commented Feb 6, 2024

@timholy I'm not volunteering for this, I just noticed this PR and that OP said

This is my first contribution to Julia, or any software package for that matter, so any help would be greatly appreciated.

so I figured I could let OP know what's going on, so they'd understand why they haven't heard anything.

@kimikage
Copy link
Collaborator

PR #533 was merged.

@kimikage kimikage closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants