Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cubic L2 norm, typing fixes, tests cleanup #63

Merged
merged 5 commits into from
Dec 2, 2018

Conversation

lostella
Copy link
Member

Partially addresses #58 by adding cube Euclidean norm and tests for it, cleans some of the existing functions (in the typing and type parameters mostly), improves some of the existing tests.

@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #63 into master will decrease coverage by 0.41%.
The diff coverage is 77.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   60.94%   60.52%   -0.42%     
==========================================
  Files          70       71       +1     
  Lines        2038     2052      +14     
==========================================
  Hits         1242     1242              
- Misses        796      810      +14
Impacted Files Coverage Δ
src/ProximalOperators.jl 48% <ø> (ø) ⬆️
src/functions/sqrNormL2.jl 76% <ø> (ø) ⬆️
src/functions/indBallL0.jl 65.51% <100%> (ø) ⬆️
src/functions/indHyperslab.jl 84% <100%> (ø) ⬆️
src/functions/indBallL1.jl 51.16% <62.5%> (ø) ⬆️
src/functions/cubeNormL2.jl 68.75% <68.75%> (ø)
src/calculus/conjugate.jl 57.69% <87.5%> (-3.03%) ⬇️
src/functions/normL1.jl 55.07% <0%> (-11.6%) ⬇️
src/functions/linear.jl 66.66% <0%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9935cd0...fa6dc89. Read the comment docs.

@lostella lostella merged commit e7479b3 into JuliaFirstOrder:master Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant