Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding indicator of polyhedral set #54

Merged
merged 7 commits into from
May 31, 2018
Merged

Adding indicator of polyhedral set #54

merged 7 commits into from
May 31, 2018

Conversation

lostella
Copy link
Member

This adds the indicator of a polyhedral set

{x : xmin <= x <= xmax, l <= Ax <= u}

For the moment, the projection is only implemented using OSQP. This PR is backward compatible in that it just adds a function. The only additional change is a minor modification to a test routine.

@lostella
Copy link
Member Author

lostella commented Apr 13, 2018

Relevant for #52

@codecov
Copy link

codecov bot commented Apr 13, 2018

Codecov Report

Merging #54 into master will decrease coverage by 0.15%.
The diff coverage is 97.22%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #54      +/-   ##
========================================
- Coverage   92.16%    92%   -0.16%     
========================================
  Files          67     69       +2     
  Lines        1991   2039      +48     
========================================
+ Hits         1835   1876      +41     
- Misses        156    163       +7
Impacted Files Coverage Δ
src/ProximalOperators.jl 100% <ø> (ø) ⬆️
src/functions/indPolyhedralOSQP.jl 100% <100%> (ø)
src/functions/indPolyhedral.jl 80% <80%> (ø)
src/functions/indHalfspace.jl 76% <0%> (-20%) ⬇️
src/calculus/translate.jl 52% <0%> (-4%) ⬇️
src/functions/indExp.jl 93.42% <0%> (-3.95%) ⬇️
src/functions/linear.jl 38.09% <0%> (+0.59%) ⬆️
src/functions/logisticLoss.jl 90.24% <0%> (+2%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d13d2...c44a7ad. Read the comment docs.

@lostella lostella merged commit 98d9e08 into master May 31, 2018
@lostella lostella deleted the polyhedra branch May 31, 2018 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant