Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial bubble sort swaps #393

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Spatial bubble sort swaps #393

wants to merge 3 commits into from

Conversation

kahaaga
Copy link
Member

@kahaaga kahaaga commented Jan 18, 2024

While working on the "accelerating research" section of the paper, I decided to do an experiment to see how efficient our APIs are.

I wanted to see how long it would take to generalize one of the existing outcome spaces to another spatial outcome space. The conclusion: it took roughly 2 hours, from conceiving the idea to finishing this PR.

Contents of this PR

Introduces a new spatial outcome space: SpatialBubbleSortSwaps which encodes based on the "bubble sorting complexity" of the elements of hypervoxel windows. This works very similarly to SpatialOrdinalPatterns and SpatialDispersion, except the encoding is in terms of how many swaps are necessary to sort each window.

  • Implemented codify, counts_and_outcomes, total_outcomes and outcome_space.
  • Pretty printing of the constructor (including tests).
  • Tests.
  • Referred to in docs.
  • Added change log entry
  • Minor version increment.

@kahaaga kahaaga requested a review from Datseris January 18, 2024 11:55
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (70c4ab0) to head (9241235).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   88.74%   88.83%   +0.08%     
==========================================
  Files          85       86       +1     
  Lines        2444     2463      +19     
==========================================
+ Hits         2169     2188      +19     
  Misses        275      275              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Datseris
Copy link
Member

Any outcome space that does delay embeddings is immediatelly generalizable to spatial data. We just need to alter codify for it so that it does different embedding and construction of the vector of vectors (vectors of views in this case to be precise). But I guess we should leave this for another point. I would much rather finish the paper now. I am really in despearate stress to finish projects and publish them!

Project.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants