Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve formula presentation #697

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

junyixu
Copy link

@junyixu junyixu commented Mar 25, 2024

No description provided.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.57%. Comparing base (c310fb5) to head (27b4d09).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files          11       11           
  Lines         969      969           
=======================================
  Hits          868      868           
  Misses        101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasnoack
Copy link
Member

Would be good to show the before and after in a comment

@junyixu
Copy link
Author

junyixu commented Mar 25, 2024

Before:
image

After:
Screenshot_20240325_193632

@junyixu
Copy link
Author

junyixu commented Mar 25, 2024

I'm not sure. Represent a function $f$ that maps an element $x$ in a set to another element $y$:
$$f: x \mapsto y.$$
But in the original doc page,
image
it seems the author intended to use \to to represent a type of change.

@mcabbott
Copy link
Member

Sorry just went by your pictures, where after used it for two kinds of change. x to x_eps, and x_eps to f(x_eps). It seems the original commits the same sin, could fix that too?

…\to`

Co-authored-by: Michael Abbott <32575566+mcabbott@users.noreply.github.com>
@junyixu
Copy link
Author

junyixu commented Mar 26, 2024

Sorry just went by your pictures, where after used it for two kinds of change. x to x_eps, and x_eps to f(x_eps). It seems the original commits the same sin, could fix that too?

I force-pushed a new commit. What do you think?

Before:
image

After:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants