Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Make hash(::CategoricalValue) faster by pre-computing hashes #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nalimilan
Copy link
Member

This optimization only works for the one-argument hash() method: when a hash
code is passed, the hash needs to be recomputed anyway. This can still be useful
for hashing DataTables columns.

This optimization only works for the one-argument hash() method: when a hash
code is passed, the hash needs to be recomputed anyway. This can still be useful
for hashing DataTables columns.
@nalimilan nalimilan mentioned this pull request Mar 7, 2017
@coveralls
Copy link

coveralls commented Mar 7, 2017

Coverage Status

Coverage decreased (-0.3%) to 90.963% when pulling 3d3aa36 on nl/hash into b88769b on master.

@codecov-io
Copy link

codecov-io commented Mar 7, 2017

Codecov Report

Merging #61 into master will decrease coverage by -0.35%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage    91.3%   90.96%   -0.35%     
==========================================
  Files           9        9              
  Lines         506      509       +3     
==========================================
+ Hits          462      463       +1     
- Misses         44       46       +2
Impacted Files Coverage Δ
src/pool.jl 95.83% <0%> (-1.01%)
src/typedefs.jl 100% <100%> (ø)
src/value.jl 68.29% <100%> (-1.71%)
src/buildfields.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b88769b...3d3aa36. Read the comment docs.

@nalimilan
Copy link
Member Author

x-ref JuliaData/DataFrames.jl#1565.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants