When Base has the unwrap function, we can avoid defining generic fall… #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…back convert methods that cause lots of recompilation of convert methods. This improves the package load times from 1.4s to 1.0s for me. Fixes #177. Failures on nightly are unrelated
nalimilan
reviewed
Jul 26, 2019
|
|
||
| # Defined separately to avoid ambiguities | ||
| Base.convert(::Type{AbstractString}, x::CategoricalString) = x | ||
| Base.convert(::Type{T}, x::T) where {T <: CatValue} = x | ||
| Base.convert(::Type{Union{T, Missing}}, x::T) where {T <: CatValue} = x | ||
| Base.convert(::Type{Union{T, Nothing}}, x::T) where {T <: CatValue} = x | ||
|
|
||
| @static if isdefined(Base, :unwrap) |
There was a problem hiding this comment.
Please switch to a VERSION check once the PR is merged in Julia, so that Femtocleaner automatically removes the code the day we will require Julia 1.3.
| # General fallbacks | ||
| Base.convert(::Type{S}, x::T) where {S, T <: CatValue} = | ||
| T <: S ? x : convert(S, get(x)) |
There was a problem hiding this comment.
Just to be sure, do things like convert(CategoricalValue, x::CategoricalValue{String,UInt32}) work with this PR? That was handled by the T<:S branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…back convert methods that cause lots of recompilation of convert methods. This improves the package load times from 1.4s to 1.0s for me. Fixes #177. Failures on nightly are unrelated
Relies on JuliaLang/julia#32613 for
Base.unwrap