Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum Julia version to 1.6 #366

Merged
merged 3 commits into from May 2, 2024
Merged

Conversation

Zentrik
Copy link
Contributor

@Zentrik Zentrik commented Apr 26, 2024

Split out from #347, LinuxPerf doesn't support 1.0 as it depends on PrettyTables which doesn't. Also, buildkite doesn't seem to support it either.
1.0 seems sufficiently old that it seems fine to me to drop support.

@Zentrik Zentrik mentioned this pull request Apr 26, 2024
Copy link
Collaborator

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, revising my earlier comment. shouldn't these 5 lines just read the package toml? Otherwise we would need to update this version every time.

Copy link
Collaborator

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take this opportunity to remove a hard-coded version string

src/BenchmarkTools.jl Outdated Show resolved Hide resolved
@willow-ahrens willow-ahrens merged commit 0941fd1 into JuliaCI:master May 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants