Fix a bug in tests of imf #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An imf test case returns [[0.0389489], [0.0273499]] but tests with isapprox against [0.0389489, 0.0273499]. For some reason this breaks in 0.7/1.0 (changes in broadcast?).
|
I assume the test fail is because of (JuliaLang/julia#26435). The reason that your checks are failing for the windows builds are mainly because the appveyor.yml file has to be updated, to match the recent changes in https://github.com/JuliaCI/Appveyor.jl. |
|
I updated the AppVeyor script in master, I'm going to merge this |
|
Seems to work also on AppVeyor: https://ci.appveyor.com/project/giordano/astrolib-jl/build/1.0.302 Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An imf test case returns [[0.0389489], [0.0273499]] but tests with
isapprox against [0.0389489, 0.0273499]. For some reason this breaks
in 1.0 (changes in broadcast?).