Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Types extension #158

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MartinuzziFrancesco
Copy link

This PR is meant to extend the package to return output with matching typing of the given input data. Specifically I am adding the flexibility to all functions to handle Float64 as well as Float32 and Float16.

This is PR is a heavy work in progress at the moment, I'm mercilessly dispatching on all functions that need changing, but I think at the end there's going to be redundant code, I'll sweep through everything at the end.

Tentative (and living) checklist of stuff to add

  • Dispatch fit folder functions
  • Dispacth glr folder functions (underway)
  • Dispatch loss-penalty folder functions (underway)
  • Dispatch mlj folder functions
  • tests

@ablaom ablaom marked this pull request as draft March 10, 2024 19:56
@adienes
Copy link
Contributor

adienes commented Mar 11, 2024

fit(::Type{T}, glr::GLR, X::AbstractMatrix{<:Real},

why introduce an argument rather than using the type of X?

@MartinuzziFrancesco
Copy link
Author

yes there are a lot of redundancies at the moment, I started this top down while I was digging into the code instead of bottom up. I'll be fixing a lot of these in the next push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants