Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ NEW: Add FleurHubbard1WorkChain #162

Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from
Draft

Conversation

janssenhenning
Copy link
Contributor

Add Workchain for performing Hubbard 1 calculations

@janssenhenning janssenhenning force-pushed the hubbard1_wc branch 2 times, most recently from 9630f2b to cacfbdb Compare March 31, 2022 10:16
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Base: 77.00% // Head: 76.22% // Decreases project coverage by -0.77% ⚠️

Coverage data is based on head (9426197) compared to base (526248c).
Patch coverage: 27.61% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #162      +/-   ##
===========================================
- Coverage    77.00%   76.22%   -0.78%     
===========================================
  Files          119      120       +1     
  Lines        14808    15042     +234     
===========================================
+ Hits         11403    11466      +63     
- Misses        3405     3576     +171     
Impacted Files Coverage Δ
aiida_fleur/workflows/hubbard1.py 17.70% <17.70%> (ø)
aiida_fleur/workflows/scf.py 72.29% <60.00%> (-0.67%) ⬇️
aiida_fleur/calculation/fleur.py 71.82% <75.00%> (-0.05%) ⬇️
tests/test_entrypoints.py 100.00% <100.00%> (ø)
tests/test_workflows_builder_init.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

janssenhenning and others added 23 commits September 21, 2022 13:33
For now all files are retrieved. It might be better to limit the
data
the previous condition would abort always if the criteria were reached
Otherwise return_results is executed twice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant