Add typeof window checks for SSR #277
Open
+95
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes I was able to get this branch working with nuxt
…On Tue., 25 Apr. 2017, 12:15 pm kodekrendel, ***@***.***> wrote:
@MarcoThePoro <https://github.com/MarcoThePoro> hello. Does this mean
that Keen now work with Nuxt?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#277 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHazr_SOa9Wxzv61OBL9E7slBRajjZGQks5rzVdOgaJpZM4MZ9hr>
.
|
|
Does SSR support are present in current release? |
|
Currently Keen UI has no support for SSR. Full SSR support will be Keen UI v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added checks for the
windowglobal before any accesses towindowordocumentso that Keen-UI can be used for SSR (and nuxt.js).UiTooltip.vueandUiPopover.vuehave a conditional require becausetether-drophas a side effect which accessesdocumenton require, andtether-tooltipalso depends ontether-drop.I used
requires instead ofimport()s to avoid having to deal with async.Would close #261