New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paper CommandAPI #517
Draft
DerEchtePilz
wants to merge
28
commits into
dev/dev
Choose a base branch
from
dev/commandapi-paper
base: dev/dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Paper CommandAPI #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
DerEchtePilz
force-pushed
the
dev/commandapi-paper
branch
2 times, most recently
from
February 9, 2024 20:48
46558a5
to
9babcd2
Compare
DerEchtePilz
force-pushed
the
dev/commandapi-paper
branch
from
February 21, 2024 12:37
9babcd2
to
330f113
Compare
Merged
DerEchtePilz
force-pushed
the
dev/commandapi-paper
branch
from
February 28, 2024 16:01
9102ea7
to
bfbe182
Compare
DerEchtePilz
force-pushed
the
dev/commandapi-paper
branch
from
March 30, 2024 09:24
bfbe182
to
c5d49e1
Compare
DerEchtePilz
force-pushed
the
dev/commandapi-paper
branch
from
March 30, 2024 13:12
4dba32a
to
9f28b25
Compare
DerEchtePilz
force-pushed
the
dev/commandapi-paper
branch
2 times, most recently
from
April 11, 2024 15:10
b088d05
to
a93af70
Compare
DerEchtePilz
force-pushed
the
dev/commandapi-paper
branch
5 times, most recently
from
May 7, 2024 18:49
18e8c28
to
f80d789
Compare
DerEchtePilz
force-pushed
the
dev/commandapi-paper
branch
from
May 9, 2024 20:37
36ca865
to
acda2d1
Compare
DerEchtePilz
added a commit
that referenced
this pull request
May 12, 2024
+ fixed exception appearing in server log, this isn't done with VarHandles but I think because this is a hotfix, it is fine for now. I will handle all this properly on dev/commandapi-paper and #517
DerEchtePilz
force-pushed
the
dev/commandapi-paper
branch
4 times, most recently
from
May 13, 2024 16:28
04d7e5e
to
89450e0
Compare
Does it compile? Because it doesn't for me.
Of course, temporarily :D
DerEchtePilz
force-pushed
the
dev/commandapi-paper
branch
2 times, most recently
from
May 13, 2024 16:47
6ae7c55
to
da64e4e
Compare
This needs testing. Definitely.
DerEchtePilz
force-pushed
the
dev/commandapi-paper
branch
from
May 14, 2024 13:17
f9a99ef
to
c357912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors parts of the CommandAPI so the Adventure library and Bungee library aren't used in the same .jar's anymore and Paper API and Spigot API also aren't used together anymore.
In order to do that,
commandapi-bukkit-core
only serves as a tool to access NMS so it can be shared and doesn't have to be implemented again for Paper and Spigot.The new usable platforms are
commandapi-paper-(core/shade/plugin)
andcommandapi-spigot-(core/shade/plugin)
.This still requires a lot of work. I am fairly confident that these changes should already make a fairly functional CommandAPI for Paper and Spigot, however, there still is a lot of work left.
This should also invalidate #474 as this refactor puts them into different modules
TODO's:
PaperImplementations.java
CommandAPIBukkit
and implement inCommandAPIPaper
andCommandAPISpigot
respectively.commandapi-annotations
platform specific (Component related arguments)CommandAPIPaper
orCommandAPISpigot
. Maybe even both, share tests and implement component related arguments for both platforms