Remove nvim-treesitter, use nvim 0.9+ core utilities #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoosepAlviste
requested changes
Nov 11, 2023
Slotos
force-pushed
the
be-a-plugin
branch
3 times, most recently
from
241d289
to
05f632e
Compare
|
This looks great now! Just the Stylua check to fix and the deprecation message wording, and then we can merge it 🎉 Thanks for taking care of the fixes and improvements! |
DEPRECATED context_commentstring nvim-treesitter module, use
require('ts_context_commentstring').setup {} instead.
With 0.9 being the minimal version for this plugin, nvim-treesitter is
quite literally a fifth wheel for its functionality. It installs and
updates parsers, but everything this plugin needs to operate afterwards
is available in the core `vim.treesitter` utilities set.
I also borrowed a test setup from aerial.nvim, to create a minimal
setup launcher bash script that truly isolates minimal config from
main user configuration.
Sh is handled by bash tree-sitter parser.
`vim.treesitter.language.get_lang('sh')` returns `bash`.
This change makes this plugin work with both sh and bash files.
JoosepAlviste
approved these changes
Nov 18, 2023
Open
|
Thanks for the great work on this! It feels great to get rid of some useless code 🎉 I also created an issue with the breaking changes and mentioned this there: #82 (comment) and updated the integrations wiki: https://github.com/JoosepAlviste/nvim-ts-context-commentstring/wiki/Integrations. Hopefully this won't be too big of a pain for users 🤞 |
aknackd
added a commit
to aknackd/dotfiles
that referenced
this pull request
Nov 21, 2023
…ommentstring deprecation message See JoosepAlviste/nvim-ts-context-commentstring#80 for more context
fitrh
added a commit
to fitrh/init.nvim
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 0.9 being the minimal version for this plugin, nvim-treesitter is quite literally a fifth wheel for its functionality. It installs and updates parsers, but everything this plugin needs to operate afterwards is available in the core
vim.treesitterutilities set.I also borrowed a test setup from aerial.nvim, to create a minimal setup launcher bash script that truly isolates minimal config from main user configuration.