Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent StreamingPayment uninstallation if pending streams remain #1251

Draft
wants to merge 3 commits into
base: maint/single-stream-payments
Choose a base branch
from

Conversation

area
Copy link
Member

@area area commented May 8, 2024

The main feature here is to prevent uninstallation of the extension in the event that there are some streaming payments unclaimed. It also:

  • Reworks some calculations to prevent over/underflows. This is somewhat opinionated in that the intention is to 'cap' the calculations
  • Allows editing of the interval, which is a requirement. While in an ideal world, editing the interval shouldn't be necessary as you could edit the amount, rounding errors meant that this should be editable as well. This is possible as we have moved to single-stream payments.

@area area force-pushed the maint/single-stream-payments branch from 1a54bad to a17d2b7 Compare May 8, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant