Streaming payments only support a single stream #1250
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area
force-pushed
the
maint/single-stream-payments
branch
from
1a54bad
to
a17d2b7
Compare
| @@ -247,44 +228,13 @@ contract StreamingPayments is ColonyExtensionMeta { | |||
| _toChildSkillIndex, | |||
| _id, | |||
| domainFundingPotId, | |||
| _tokens, | |||
| amountsToClaim | |||
| toAddressArray(streamingPayment.token), | |||
There was a problem hiding this comment.
I would re-implement setupExpenditure not to take an array, rather than coerce the token into an array of one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB Based on maint/pnpm.
Multiple streams in a single streaming payment are no longer desired on the frontend, so taking the opportunity to simplify the contracts. This will also allow accurate tracking of the number of pending payments, allowing the 'prevent uninstall if pending payments' feature.
I've taken advantage of
finishUpgradeto make sure someone can't upgrade from v4 to v5, which we are declaring is impossible due to the storage layout changes.