Add support for the target attribute in a FormContext #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnSundell
reviewed
Mar 18, 2020
| /// Assign a target to the form, specifying where the response | ||
| /// received after submitting the form should be displayed. | ||
| /// - parameter target: The target to assign. See `HTMLAnchorTarget`. | ||
| static func target(_ target: HTMLAnchorTarget) -> Node { |
There was a problem hiding this comment.
I think, along with this, we should rename HTMLAnchorTarget to something more appropriate (now that it's not only used for anchors) - for example HTMLBrowserTarget, since it's all about assigning a target for the browser to display a page in.
JohnSundell
added
the
awaiting update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
targetform attribute, which was previously only available in AnchorContext when using Plot. On forms, it specifies where the response received after submitting the form should be shown.