Skip to content
This repository has been archived by the owner on Jan 4, 2020. It is now read-only.

Use --package-path instead of the deprecated -C flag. #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaandedeoglu
Copy link

This fixes a build issue when using Marathon with Swift 4.

This PR should probably wait here until Xcode 9 & Swift 4 is officially out.

@JohnSundell
Copy link
Owner

JohnSundell commented Sep 4, 2017

Thanks for this @kaandedeoglu! 🙌 How about doing this only if the user is running Swift 4? I don't want to be too aggressive dropping support for Swift 3, since people might have scripts running on CI etc that might take a while to get on Swift 4/Xcode 9.

PackageManager has a resolveSwiftToolsVersion() method which can be used to resolve the current Swift version. It's private right now, but we could move that somewhere where Script can access it as well.

@kaandedeoglu
Copy link
Author

Sure thing! I'll take a look and restrict the change for Swift 4+. And not a problem at all, I love Marathon :-)

@JohnSundell
Copy link
Owner

@kaandedeoglu awesome to hear 🎉

@dyna-dot
Copy link

dyna-dot commented Oct 1, 2019

Hi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants