New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass all decoded data to onScan #173

Open

educastellano wants to merge 2 commits into JodusNodus:master from educastellano:feature/pass-all-data-to-onscan

educastellano commented Sep 14, 2020

I need to read binary data from a QR code and there's already support in the jsqr library but the data isn't passed to the onScan() handler.

Would it be ok to pass the whole object returned from jsqr?

function handleScan({ data, binaryData, ...rest }) {
  console.log(data, binaryData, ...rest)
}

This would be a breaking change so it needs a major version.

educastellano added 2 commits

September 14, 2020 13:29


          Update package-lock.json

9b750b5


          Pass all the data decoded from jsqr to the onScan handler (data, bina…

aac8097

…ryData, chunks and location)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment