Package JSON and init wrapper #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there. Thanks for the effort you've put into building this little script. It makes for a great, free alternative to more complex 360 viewers.
I did find that setting up the viewer was fairly complicated, as the script makes a few undisclosed assumptions, and the function it exposes is a little too inelegant to my taste.
It works all the same, and the script can be used in the same way it could before: I haven't changed any functionality apart from creating a dummy-element if none exists rather than assuming that it does.
Let me know if you have questions :-)