Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KT-67041] Prevent KCallableImpl.parameters from being released #5283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −4
Open

[KT-67041] Prevent KCallableImpl.parameters from being released #5283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions core/reflection.jvm/src/kotlin/reflect/jvm/internal/KCallableImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ internal abstract class KCallableImpl<out R> : KCallable<R>, KTypeParameterOwner

override val annotations: List<Annotation> get() = _annotations()

private val _parameters = ReflectProperties.lazySoft {
// See KT-67041 for why this property is not lazySoft
override val parameters by lazy(LazyThreadSafetyMode.PUBLICATION) {
val descriptor = descriptor
val result = ArrayList<KParameter>()
var index = 0
Expand Down Expand Up @@ -69,9 +70,6 @@ internal abstract class KCallableImpl<out R> : KCallable<R>, KTypeParameterOwner
result
}

override val parameters: List<KParameter>
get() = _parameters()

private val _returnType = ReflectProperties.lazySoft {
KTypeImpl(descriptor.returnType!!) {
extractContinuationArgument() ?: caller.returnType
Expand Down