Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make K2 incompatible ObjCName error consistent with K1 #5259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarkCMann
Copy link
Contributor

@MarkCMann MarkCMann commented Feb 5, 2024

This changes the K2 error message from:

Repro.kt:16:1: error: member 'class DerivedFoo : AbstractFoo, IFoo' inherits inconsistent '@ObjCName' from '[class AbstractFoo : Any, interface IFoo : Any]'.
class DerivedFoo : AbstractFoo(), IFoo {}
^

To:

Repro.kt:16:1: error: member '@ObjCName(...) fun foo(): Unit' inherits inconsistent '@ObjCName' from '[class AbstractFoo : Any, interface IFoo : Any]'.
class DerivedFoo : AbstractFoo(), IFoo {}
^

Which is more in line with the error from 1.9:

/Users/markmann/incompatible-objc-name/Repro.kt:16:1: error: member "foo" inherits inconsistent @ObjCName from AbstractFoo, IFoo
class DerivedFoo : AbstractFoo(), IFoo {}
^

^KT-65572

@ejller
Copy link
Contributor

ejller commented Feb 14, 2024

@mglukhikh could you take a look?

@ejller
Copy link
Contributor

ejller commented Feb 16, 2024

Fixed - ec12637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants