Coil3 isnt quite working #327
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rock3r
reviewed
Mar 22, 2024
| @@ -12,6 +12,8 @@ Additional supported Markdown, via extensions: | |||
|
|
|||
| * Alerts ([GitHub Flavored Markdown][alerts-specs]) — see [`extension-gfm-alerts`](extension-gfm-alerts) | |||
|
|
|||
| Im**agetime, and no guarantees are made for binary and source compatibility. It might also have bugs and missing features.  And ot**her stuff time, and no guarantees are made for binary and source compatibility. It might also have bugs and missing features. time, and no guarantees are made for binary and source compatibility. It might also have bugs and missing features. | |||
| @@ -144,7 +151,7 @@ public class MarkdownProcessor(private val extensions: List<MarkdownProcessorExt | |||
| private fun Image.toMarkdownImageOrNull(): MarkdownBlock.Image? { | |||
| if (destination.isBlank()) return null | |||
|
|
|||
| return MarkdownBlock.Image(destination.trim(), title.trim()) | |||
| return MarkdownBlock.Image(destination.trim(), (title?:"").trim()) | |||
There was a problem hiding this comment.
Suggested change
| return MarkdownBlock.Image(destination.trim(), (title?:"").trim()) | |
| return MarkdownBlock.Image(destination.trim(), title.orEmpty().trim()) |
rock3r
reviewed
Mar 22, 2024
| implementation("io.coil-kt.coil3:coil-compose:3.0.0-alpha06") | ||
| // Exception in thread "AWT-EventQueue-0" java.lang.IllegalStateException: Module with the Main dispatcher is missing. Add dependency providing the Main dispatcher, e.g. 'kotlinx-coroutines-android' and ensure it has the same version as 'kotlinx-coroutines-core' | ||
| // https://github.com/coil-kt/coil/issues/842#issuecomment-1975115060 | ||
| runtimeOnly("org.jetbrains.kotlinx:kotlinx-coroutines-swing:1.8.1-Beta") |
There was a problem hiding this comment.
This will break in the IDE, we can't bring coroutine dependencies in. We need to use those that the platform has.
fscarponi
reviewed
Apr 4, 2024
| is Paragraph -> toMarkdownParagraphOrNull() | ||
| is Paragraph -> { | ||
| val child = firstChild | ||
| if (child is Image && child === lastChild) { |
There was a problem hiding this comment.
@rock3r Could this be written better? (does "===" operator be error prone?)
There was a problem hiding this comment.
The === check makes the is check pointless I suppose — but I haven't checked the code too thoroughly yet, since Oleg said it's not really working anyway. I'm not sure why we need a ref equality check here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.