Add strikethrough markdown support #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it's inlined, the extension is added directly to the core module.
rock3r
reviewed
Mar 22, 2024
There was a problem hiding this comment.
The PR looks good, but I would prefer if we didn't have extensions bundled in the core module. I know it's a bit more work to fully support inline extensions, but the skeleton should already be there. Can you extract the strikethrough code to an extension-gfm-strikethrough module?
| @@ -49,3 +50,5 @@ gradleEnterprise { | |||
| termsOfServiceAgree = "yes" | |||
| } | |||
| } | |||
| include("markdown:commonmark-extensions") | |||
| findProject(":markdown:commonmark-extensions")?.name = "commonmark-extensions" | |||
There was a problem hiding this comment.
I'm not sure why this is added here. We don't have such a module in the project, as far as I can see
|
@obask this requires a rebase/cleanup after the latest changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's inlined, the extension is added directly to the core module.