Fix clearing highlighted yank in editors within modal dialogs #871
+198
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a memory leak registering a disposable for each yank, allows config variables to be numbers rather than strings and removes highlights when IdeaVim is disabled Fixes VIM-2236
citizenmatt
force-pushed
the
bugfix/highlighted-yank-fixes
branch
from
356a9ff
to
f6acbfa
Compare
|
Looks good to me, thank you for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a modality issue with the timer to clear the highlighted yank extension's highlights. If the editor was hosted inside a modal dialog (e.g. Live Templates in Settings), or shown from a modal dialog (e.g. Resolve Conflicts dialog), then the timer callback would wait for the modal dialog to close before clearing the highlights. This fixes VIM-2236.
These changes also fix some other minor issues with the highlighted yank extension:
g:highlightedyank_highlight_durationcan be a number as well as a string, matching the original Vim plugin.